Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: reduce FE e2e ci time #1698

Merged
merged 8 commits into from
Apr 3, 2021
Merged

chore: reduce FE e2e ci time #1698

merged 8 commits into from
Apr 3, 2021

Conversation

LiteSun
Copy link
Member

@LiteSun LiteSun commented Mar 31, 2021 •
edited
Loading

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?
Currently, front-end e2e CI takes around 40+ minutes to run through. This PR is used to reduce the front-end e2e time by about 20mins.

Related issues

resolves #1614

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@LiteSun LiteSun changed the title Reduce fe ci time feat: reduce FE e2e ci time Mar 31, 2021
juzhiyuan
juzhiyuan reviewed Mar 31, 2021
View reviewed changes
.github/workflows/frontend-e2e-test.yml Outdated Show resolved Hide resolved
web/cypress.json Show resolved Hide resolved
@juzhiyuan
Copy link
Member

If this PR works and gets merged, it will save a lot of us life!!

@LiteSun
Copy link
Member Author

LiteSun commented Mar 31, 2021

There was a problem with the node_modules cache, Will fix it later.

@codecov-io
Copy link

codecov-io commented Mar 31, 2021 •
edited
Loading

Codecov Report

Merging #1698 (2d6887c) into master (37f4cd8) will decrease coverage by 1.01%.
The diff coverage is n/a.

❗ Current head 2d6887c differs from pull request most recent head 87f6ac6. Consider uploading reports for the commit 87f6ac6 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1698      +/-   ##
==========================================
- Coverage   72.70%   71.68%   -1.02%     
==========================================
  Files         133       47      -86     
  Lines        5738     3126    -2612     
  Branches      666        0     -666     
==========================================
- Hits         4172     2241    -1931     
+ Misses       1323      643     -680     
+ Partials      243      242       -1
Flag Coverage Δ
backend-e2e-test 62.44% <ø> (+0.09%) ⬆️
backend-e2e-test-ginkgo 48.72% <ø> (+0.22%) ⬆️
backend-unit-test 52.29% <ø> (ø)
frontend-e2e-test ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/internal/core/store/store.go 89.15% <0.00%> (ø)
...eb/src/pages/PluginTemplate/components/Preview.tsx
...pages/Route/components/Step1/RequestConfigView.tsx
web/src/pages/Service/components/Preview.tsx
web/src/components/Plugin/PluginDetail.tsx
web/src/services/user.ts
web/src/pages/SSL/List.tsx
web/src/pages/User/Login.tsx
web/src/pages/Upstream/Create.tsx
web/src/components/Upstream/UpstreamForm.tsx
... and 78 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37f4cd8...87f6ac6. Read the comment docs.

moonming
moonming reviewed Apr 1, 2021
View reviewed changes
.github/workflows/frontend-e2e-test.yml Outdated Show resolved Hide resolved
.github/workflows/frontend-e2e-test.yml
@@ -37,31 +37,54 @@ jobs:
- name: Setup golang environment
uses: actions/setup-go@v2.1.3
with:
go-version: "1.13"
go-version: '1.13'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest of the formatting has been changed. The official documentation for this place uses single quotes, so let's leave it as it is, probably having changed the formatting wrong before.

image

@juzhiyuan juzhiyuan changed the title feat: reduce FE e2e ci time chore: reduce FE e2e ci time Apr 2, 2021
@LiteSun LiteSun requested review from starsz, nic-chen and liuxiran April 2, 2021 02:49
@juzhiyuan juzhiyuan requested review from imjoey and Yiyiyimu April 2, 2021 10:11
@juzhiyuan
Copy link
Member

ping

@Yiyiyimu Yiyiyimu merged commit 297a57a into apache:master Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yiyiyimu Yiyiyimu Yiyiyimu approved these changes

@moonming moonming moonming approved these changes

@liuxiran liuxiran liuxiran approved these changes

@juzhiyuan juzhiyuan juzhiyuan approved these changes

@starsz starsz Awaiting requested review from starsz

@nic-chen nic-chen Awaiting requested review from nic-chen

@imjoey imjoey Awaiting requested review from imjoey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimized front-end e2e test time
6 participants
@LiteSun @juzhiyuan @codecov-io @liuxiran @moonming @Yiyiyimu